Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ne3np4 to list of surface dataset resolutions #2768

Open
5 tasks done
ekluzek opened this issue Sep 17, 2024 · 17 comments · May be fixed by #2835
Open
5 tasks done

Add ne3np4 to list of surface dataset resolutions #2768

ekluzek opened this issue Sep 17, 2024 · 17 comments · May be fixed by #2835
Assignees
Labels
bfb bit-for-bit enhancement new capability or improved behavior of existing capability priority: low Background task that doesn't need to be done right away. science Enhancement to or bug impacting science

Comments

@ekluzek
Copy link
Collaborator

ekluzek commented Sep 17, 2024

For support of SCAM we need to support ne3np4 in addition to ne3np4.pg3 as pointed out by @jtruesdal.

Definition of done:

  • Create the needed files from a branch tag of ctsm5.3.0 (do rest on b4b-dev)
  • Add build of ne3np4 for same configurations as ne3np4.pg3 (1850, 2000, Hist, SSP2-4.5) to mksurfdata_esmf Makefile
  • Add the files into namelist_defaults
  • Add a test for it to the build-namelist tester
  • Add a SCAM test using it to aux_clm (and ctsm_sci?)
@ekluzek ekluzek added enhancement new capability or improved behavior of existing capability bfb bit-for-bit science Enhancement to or bug impacting science labels Sep 17, 2024
@ekluzek ekluzek added this to the ctsm5.3.0 milestone Sep 17, 2024
@ekluzek
Copy link
Collaborator Author

ekluzek commented Sep 17, 2024

Pinging @slevis-lmwg I put this as something to do as part of ctsm5.3.0, but we could do it in a post ctsm5.3.0 tag. It's easy to do, but involves enough steps that it could be done later.

@wwieder
Copy link
Contributor

wwieder commented Sep 17, 2024

I'll let others evaluate the timing here, but I worry about scope creep and further delays for making a CTSM5.3.0 and CESM_beta03 tags

@wwieder
Copy link
Contributor

wwieder commented Sep 17, 2024

Towards that end, I don't know this is show stopper for the scientific applications we need to meet for the 5.3 milestone or the "Aug" code chill, but we can discuss here or on Thurs.

@ekluzek
Copy link
Collaborator Author

ekluzek commented Sep 18, 2024

I asked @jtruesdal offline and needs to have access to the files right away, but doesn't need it in a tag right away. So here's the plan

  • We'll make the files with a branch tag when Derecho comes back up
  • We'll add this work to b4b-dev and have it come in on the b4b-dev cycle...

@slevis-lmwg
Copy link
Contributor

slevis-lmwg commented Sep 25, 2024

Steps in ctsm5.3.0 with the mksurfdata_esmf tool for generating the 1850 file (similarly for 2000). Includes correction discussed below:

./gen_mksurfdata_build 
./gen_mksurfdata_namelist --start-year 1850 --end-year 1850 --res ne3np4 --model-mesh /glade/campaign/cesm/cesmdata/inputdata/share/meshes/ne3np4_ESMFmesh_c230714_cdf5.nc --model-mesh-nx 488 --model-mesh-ny 1
./gen_mksurfdata_jobscript_single --namelist-file surfdata_ne3np4_hist_1850_78pfts_c240925.namelist --number-of-nodes 1
qsub mksurfdata_jobscript_single.sh 

For Hist and SSP2-4.5:

./gen_mksurfdata_namelist --start-year 1850 --end-year 2100 --res ne3np4 --model-mesh /glade/campaign/cesm/cesmdata/inputdata/share/meshes/ne3np4_ESMFmesh_c230714_cdf5.nc --model-mesh-nx 488 --model-mesh-ny 1 --ssp-rcp SSP2-4.5
./gen_mksurfdata_jobscript_single --namelist-file surfdata_ne3np4_SSP2-4.5_1850_78pfts_c240925.namelist --number-of-nodes 1
qsub mksurfdata_jobscript_single_Hist.sh

Jobs in the queue on derecho. Let's see if they work on the first attempt...

@jtruesdal
Copy link
Contributor

jtruesdal commented Sep 25, 2024 via email

@slevis-lmwg
Copy link
Contributor

You're welcome. Just to be clear though, I submitted these jobs, so you don't need to repeat the work :-)

@slevis-lmwg
Copy link
Contributor

slevis-lmwg commented Sep 26, 2024

@jtruesdal you will find the new files in
/glade/derecho/scratch/slevis/temp_work/new_rawdata/tools/mksurfdata_esmf

surfdata_ne3np4_hist_1850_78pfts_c240925.nc
surfdata_ne3np4_hist_2000_78pfts_c240925.nc

Feel free to test.

The landuse file (for transient simulations) is not ready. It ran out of wallclock with 1 node, so I gave it a second node and resubmitted.

@slevis-lmwg
Copy link
Contributor

John, the landuse file should be generated by this evening.

@ekluzek ekluzek added the priority: low Background task that doesn't need to be done right away. label Sep 27, 2024
@slevis-lmwg
Copy link
Contributor

slevis-lmwg commented Oct 16, 2024

Started testing on derecho

  • Addition to the Makefile
make crop-global-SSP2-4.5-ne3
make crop-global-1850-low-res
make crop-global-present-low-res
make global-present-low-res  (unnecessary)
  • ./build-namelist_test.pl
  • python testing
  • clm_pymods

Opening the PR next and will post updates there.

@slevis-lmwg
Copy link
Contributor

@ekluzek let's discuss the last checkbox, due to my lack of familiarity with adding SCAM tests to our test-suites.

@slevis-lmwg
Copy link
Contributor

From meeting with @ekluzek
In testlist, change ptsRLA and ptsRLO tests to ne3np4.

@slevis-lmwg
Copy link
Contributor

@jtruesdal I wonder whether you have used the above ne3np4 fsurdat file(s) successfully. If so, could you point me to a case that worked that I could look at?

@jtruesdal
Copy link
Contributor

I've only tested these with CAM3d previously and they work but when I run them in SCAM it doesn't work. The format looks strange, they are using an older? lsmlon, lsmlat dimension for the variables where as everything up to this point always used gridcell for the unstructured grid formats.

@slevis-lmwg
Copy link
Contributor

Interesting. I suspect that this is a shortcoming of our mksurfdata_esmf tool. What do you think @ekluzek?

@slevis-lmwg
Copy link
Contributor

slevis-lmwg commented Oct 25, 2024

@ekluzek and I looked into this and eventually discovered user error on my part in a line that I listed above:
./gen_mksurfdata_namelist --start-year 1850 --end-year 1850 --res ne3np4 --model-mesh /glade/campaign/cesm/cesmdata/inputdata/share/meshes/ne3np4_ESMFmesh_c230714_cdf5.nc --model-mesh-nx 1 --model-mesh-ny 488
should have been
./gen_mksurfdata_namelist --start-year 1850 --end-year 1850 --res ne3np4 --model-mesh /glade/campaign/cesm/cesmdata/inputdata/share/meshes/ne3np4_ESMFmesh_c230714_cdf5.nc --model-mesh-nx 488 --model-mesh-ny 1

I will open an issue to alert users about this pitfall and to brainstorm how to remove the pitfall.

@jtruesdal
Copy link
Contributor

jtruesdal commented Oct 25, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bfb bit-for-bit enhancement new capability or improved behavior of existing capability priority: low Background task that doesn't need to be done right away. science Enhancement to or bug impacting science
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

5 participants