Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SurvivalGames Arenas not ending properly #95

Open
ghost opened this issue Nov 3, 2013 · 38 comments
Open

SurvivalGames Arenas not ending properly #95

ghost opened this issue Nov 3, 2013 · 38 comments

Comments

@ghost
Copy link

ghost commented Nov 3, 2013

I run a massive Server and i am using the survivalgames plugin. When my arenas end, When you click to sign it says 'Cant join arena' the if you look at the sign it says 'FINISHING' and it only fixes if i restart the server but happens again when it ends.
I have redownloaded the plugin and tried a different version and this is still occurring. It does come with a crash when this happens. Please help me out!
Here is the crash http://pastebin.com/YSrD9jRV
Thanks A Lot

@Pocketkid2
Copy link

I will take a look. There are a lot of bugs like this though.

@Pocketkid2
Copy link

Is there any more error messages?

@Pocketkid2
Copy link

#96
This is what I think will fix the problem

@ghost
Copy link
Author

ghost commented Nov 4, 2013

So it's something to do with spectating that is causing it to happen?

@ghost
Copy link
Author

ghost commented Nov 4, 2013

And there are no other crashes that come with it sorry

@Pocketkid2
Copy link

Well, if you read the stack trace, it says it's getting a NullPointerException in the code for removing spectators. I took a look at the code, and I did some fixing up that might fix it. This whole plugin is full of crappy code. I'm thinking about making my own stable version

@Pocketkid2
Copy link

I am with you though I have noticed this problem since I started using it practically :)

@ghost
Copy link
Author

ghost commented Nov 4, 2013

Yeah it is crap code. That would be awesome for you to make your own. I would even pay! Do just to be clear, what should I do to fix this bug so my arenas stay working ?

@Pocketkid2
Copy link

Well, if the author approves my pull request, then maybe the bug is fixed. I will do some extensive testing, and coding of my own. I can get back to you if I get a build that works.

@ghost
Copy link
Author

ghost commented Nov 5, 2013

Oh please do! Thanks so much for that :) if you would like add my skype chrisbadaoui2000

@Pocketkid2
Copy link

Ok. I really enjoy coding Bukkit plugins. I mostly do it just for the fun of making something, and fixing things that nobody has time to fix. it's sorta my hobby :)

@Pocketkid2
Copy link

This is the first build of my in-progress re-creating of SurvivalGames. Check it out, and report any errors. We can set up skype, but later. :) http://www.mediafire.com/download/q72wd6k8dpc5ddc/SurvivalGamesReloaded.jar

@Pocketkid2
Copy link

BTW It is expected to have LOTS of errors.

@Pocketkid2
Copy link

Just fixed some more initial transfer bugs. Here ya go: http://www.mediafire.com/?hh0ysji30dqja7z

@ghost
Copy link
Author

ghost commented Nov 5, 2013

Do I set it up like the original plugin?

@Pocketkid2
Copy link

Sure. Beware it should have bugs, so you might want to just make sure your safely save and restart your server

@Pocketkid2
Copy link

I can't acces skype right now, but I will contact you via skype ASIC

@ghost
Copy link
Author

ghost commented Nov 5, 2013

No problem! Once you add me on skype I will report all the bugs to you :)

@Pocketkid2
Copy link

Ok... But you can start reporting any first bugs right now if you would. (I would like that)

@ghost
Copy link
Author

ghost commented Nov 5, 2013

No problem. Did you fix the bug where you can join arenas though ?

@ghost
Copy link
Author

ghost commented Nov 5, 2013

Also is the plugin compatible with 1.5.2? As my server is 1.5.2

@ghost
Copy link
Author

ghost commented Nov 5, 2013

With the SG plugin you made, i wanted to ask are you able to fix deathmatch up? So it counts from 10-0 then gets teleported to the middle? And do you recon its hard to add statistics to the side? Like when you join the arena, it tells you how many players have died, alive, and what arena number? Thanks so much keep up the awesome work!
BTW was this plugin meant to fix the 'cant join arena' problem?

@ghost
Copy link
Author

ghost commented Nov 5, 2013

Here is my first bug, when i try to join the arena it says ' joining arena 1' then i get tped to where i set the spawn points but i can move around and the signs dont say that i joined the arena. Here is also the error
http://pastebin.com/J42ZKbzv

@Pocketkid2
Copy link

Alright. This is just a test, to see if I can get the code to work in a new repo controlled by me, It should work with older builds, though I do compile for 1.6.4 R2.0. After I fix all the initial bugs I should be able to finish implementing all the things the previous author forgot (sponsor, deathmatch, etc...). For now I will focus on the main bugs.

@Pocketkid2
Copy link

LAWL You're error was a syntax error on my part :)

@Pocketkid2
Copy link

Alright for now try this: http://www.mediafire.com/?7zdtufe5bqnd26d

@ghost
Copy link
Author

ghost commented Nov 5, 2013

Thanks

@ghost
Copy link
Author

ghost commented Nov 5, 2013

I removed spectating and now my arenas are fine ! :D Does your build allow spectators and has that bug fixed?

@Pocketkid2
Copy link

What do you mean you 'removed spectating'? I might have fixed the bug, why don't you check for me?

@PatchGuru
Copy link

Sounds to me like your bug is in the code, that when a match ends, the plugin runs through its protocols, either missing or skipping the step that would remove the spectators from the arena once it stops, leaving it stuck in the "FINISHING" mode. I suggest you remove the entire spectating feature of this plugin or fix this bug, I gave up on this plugin when @Double0negative stopped authoring/merging solid pull requests. @Double0negative if you care about this plugin and its future, hand it off to a more capable programmer or get to work merging these solid pull requests.

@ghost
Copy link
Author

ghost commented Nov 11, 2013

Thanks so much! I removed spectators and now its working 👍

@PatchGuru
Copy link

I'm glad to hear that, check my issue request I made regarding all issues.

@ghost
Copy link
Author

ghost commented Nov 27, 2013

Pocketkid2, Sending me the source code for the latest 1.5.2 survivalgames plugin

@ghost
Copy link
Author

ghost commented Nov 28, 2013

Can you send me the source code for the latest 1.5.2 survivalgames plugin ***** SORRY

@Pocketkid2
Copy link

Why do you need the source code? I don't have 1.5.2 source, I just have my version that i'm working on for 1.6.4 RB. By the way, I got sponsoring to work!

@ghost
Copy link
Author

ghost commented Nov 28, 2013

Oh, a friend send he can fix a bug i am having with it but he said he needs the source code :/ I already asked you but you said you dont know what it is and it is related 1.5.2 but its the actual plugin itself

@Pocketkid2
Copy link

This IS the source right here! This github repo is all the current source for the plugin. I have no idea why he would want 1.5.2 as that is kinda old... (Sorry, I don't really understand what you are trying to say...)

@VillagerJeff
Copy link

Most of the code. I have a version of Survival-Games (but not the source code) where the chest levels working. The source code in the repository appears to be missing a file named "test". We don't care because we prefer to use one chest level.


From: Adam [email protected]
To: Double0negative/Survival-Games [email protected]
Sent: Friday, November 29, 2013 12:18 PM
Subject: Re: [Survival-Games] SurvivalGames Arenas not ending properly (#95)

This IS the source right here! This github repo is all the current source for the plugin. I have no idea why he would want 1.5.2 as that is kinda old... (Sorry, I don't really understand what you are trying to say...)

Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants