Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regularization with Beta not correctly implemented #2

Open
bbengfort opened this issue Jul 19, 2014 · 1 comment
Open

Regularization with Beta not correctly implemented #2

bbengfort opened this issue Jul 19, 2014 · 1 comment

Comments

@bbengfort
Copy link
Member

Although the update rule in Line 68-69 of the matrix factorization uses the regularization parameter, the error computation does not in Line 66

This computation should be corrected to:

eij += beta/2 * sum(||P||^2 + ||Q||^2 for P,Q in K)
@bbengfort
Copy link
Member Author

See the line with the secondary error computation to improve the performance of this process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bbengfort