Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use lockfile-based approach for precaching manifest for tests #10081

Open
bhollis opened this issue Nov 10, 2023 · 1 comment
Open

Use lockfile-based approach for precaching manifest for tests #10081

bhollis opened this issue Nov 10, 2023 · 1 comment

Comments

@bhollis
Copy link
Contributor

bhollis commented Nov 10, 2023

In #10068 I said:

An alternative I was thinking about was to use a lockfile strategy, leveraging node-proper-lockfile - this has the advantage of not requiring the pre-cache step but would still require most of the other machinery (deleting all but the most recent file for GHA caching, using the most recent file to avoid calling the manifest API a ton, etc) and the logic will be pretty complicated. I might try it out after this, but for now, this should resolve our test flakiness issues.

This is a good idea, even though it's complicated. The current solution really slows down running tests in VSCode.

@bhollis
Copy link
Contributor Author

bhollis commented May 4, 2024

An alternative, which may be simpler, is to store everything in a SQLite database, which natively supports multi-process concurrency via transactions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant