Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add health-check urls #1001

Closed
davidkarlsen opened this issue Apr 6, 2021 · 6 comments · Fixed by #2633
Closed

Add health-check urls #1001

davidkarlsen opened this issue Apr 6, 2021 · 6 comments · Fixed by #2633
Labels
enhancement New feature or request
Milestone

Comments

@davidkarlsen
Copy link
Contributor

Current Behavior:

No [documented] endpoints for health checks

Proposed Behavior:

add health-probes which can be used to monitor the app and it's state.

@mvanini
Copy link

mvanini commented Apr 6, 2021

For liveness and startup probes we are actually using /api/version

For readiness it can be similar to #1002

@davidkarlsen
Copy link
Contributor Author

Will that url respond even if DT has trouble connecting to the DB?

@stevespringett
Copy link
Member

Most health checks will need to be implemented in stevespringett/Alpine#22

@bodaduk
Copy link

bodaduk commented May 20, 2022

Will that url respond even if DT has trouble connecting to the DB?

This is the issue I have, /api/version still responds despite many logged db connection and other exceptions. This means health checks still pass and self healing/recovery doesn't occur.

The healthcheck we use in compose:

healthcheck: test: ["CMD", "curl", "-I", "-X", "GET", "http://localhost:8080/api/version"] interval: ${ComposeARGHealthCheckInterval:-'5m'} timeout: ${ComposeARGHealthCheckTimeout:-'30s'} retries: ${ComposeARGHealthCheckRetries:-'3'} start_period: ${ComposeARGHealthCheckStartPeriod:-'0s'}

@nscuro
Copy link
Member

nscuro commented Mar 29, 2023

I raised a PR for this in Alpine: stevespringett/Alpine#480

This will support all the various /health, /health/live, /health/ready, and /health/started endpoints.
The PR includes readiness check for database connections, but nothing else for now.

We'll need to work out other areas of the system that we can add checks for, but at least a foundation is laid.

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants