Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return type of Canadian EmissionActivityRatio function #123

Open
trevorb1 opened this issue Feb 4, 2022 · 1 comment
Open

Return type of Canadian EmissionActivityRatio function #123

trevorb1 opened this issue Feb 4, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@trevorb1
Copy link
Member

trevorb1 commented Feb 4, 2022

Most of the functions in our code base return dataframes that we append together. In the EmissionActivityRatio.py, the getCanEmissionActivityRatio() returns a list rather then a dataframe. I think we should change this for consistency sake :)

def getCanEmissionActivityRatio():
# PURPOSE: Creates EmissionActivityRatio file from Canadian data
# INPUT: N/A
# OUTPUT: dataOut = Canadian Emission Activity Ratio data

@trevorb1 trevorb1 added the enhancement New feature or request label Feb 4, 2022
@Kiel-SFU
Copy link
Collaborator

Kiel-SFU commented Feb 4, 2022

This should also be changed for ReserveMargin.py, ResidualCapacity.py, SpecifiedAnnualDemand.py, and SpecifiedDemandProfile.py.

@Kiel-SFU Kiel-SFU removed their assignment Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants