You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
for sheet in LIST_OF_SHEETS:
oldCounterList.append(collections.Counter(sheet))
newCounterList.append(collections.Counter(sheet))
Are we able to add in a statement before here that checks if the files are different? So if there are no differences, it only prints out the one line both files are the same and we don't have to look through all the print statements to see if there are issues? Or maybe only print out where the differences are? Not sure which one is better off the top of my head?
In the readme, should we change the file paths to path/to/new.txt and path/to/old.txt or something more general and shorter? Like the files don't need to be named CanadaUSA.txt?
Continuing off point 3, I really like the functionaly of this and it should work for all osemosys projects! Can we remove the places where its specific to this project? (ie. the module name and readme docs)
The text was updated successfully, but these errors were encountered:
The module
scripts/developer_tools/dataDiffCheck/
is totally functional and works great! I do have some comments/questions for improvements though :)Canada-U.S.-ElecTrade/scripts/developer_tools/dataDiffCheck/CanadaUsaTxtDiffCheck.py
Lines 105 to 107 in c8af7e6
I think we can write
Are we able to add in a statement before here that checks if the files are different? So if there are no differences, it only prints out the one line
both files are the same
and we don't have to look through all the print statements to see if there are issues? Or maybe only print out where the differences are? Not sure which one is better off the top of my head?Canada-U.S.-ElecTrade/scripts/developer_tools/dataDiffCheck/CanadaUsaTxtDiffCheck.py
Lines 111 to 117 in c8af7e6
In the readme, should we change the file paths to
path/to/new.txt
andpath/to/old.txt
or something more general and shorter? Like the files don't need to be namedCanadaUSA.txt
?The text was updated successfully, but these errors were encountered: