Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScriptExecutor does not respect variabledEnabled for VerifySchema() #5

Open
AaronShiels opened this issue Mar 31, 2020 · 0 comments
Open
Labels
bug Something isn't working

Comments

@AaronShiels
Copy link

AaronShiels commented Mar 31, 2020

Despite having the setting at it's immediate disposal in a private field, the ScriptExecutor ignores this value when verifying schema through the AdHocSqlRunner.
var sqlRunner = new AdHocSqlRunner(dbCommandFactory, sqlObjectParser, Schema, () => true);
https://github.com/DbUp/DbUp/blob/master/src/dbup-core/Support/ScriptExecutor.cs#L78

This is problematic for those extending the PostgresqlScriptExecutor and overriding GetVerifySchemaSql(string schema); to perform additional actions, such as assigning privileges to the schema and creating related roles if non-existent, as dbup-postgresql is particularly sensitive to variable issues as per #1 .

@AaronShiels AaronShiels added the bug Something isn't working label Mar 31, 2020
@droyad droyad transferred this issue from DbUp/DbUp Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Bugs
Development

No branches or pull requests

1 participant