Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to [email protected] in distribution repos #195

Open
jonathanloos opened this issue Oct 4, 2021 · 7 comments
Open

Upgrade to [email protected] in distribution repos #195

jonathanloos opened this issue Oct 4, 2021 · 7 comments

Comments

@jonathanloos
Copy link

yarn audit returning XSS vulnerability (https://snyk.io/vuln/SNYK-JS-DATATABLESNET-1540544) for datatables.net < 1.11.3. I'd like to propose an update to the distribution repositories to:

  1. datatables.net-bs4 to point to [email protected].
  2. All other distribution repos point to updated version of datatables.net-bs4.

If accepted this will be my first contribution to an open source project so please bear with me. If I missed anything here please let me know!

Best,
Jon

@AllanJard
Copy link
Contributor

Good point, we've just assumed that the dependency of >= as is at the moment is good enough. That isn't the case for something such as this.

We have scripts which can update all of the distribution repos if you don't fancy changing them all, but if you do, it will be a lot of contributions to get you started in the OSS world :-).

@jonathanloos
Copy link
Author

Hey @AllanJard ! Wow that was fast..

Although I do appreciate the exposure value for me of spraying PRs around I don't think the juice is worth the squeeze. If you guys have a tool to automate this by all means go ahead!

-Jon

@AllanJard
Copy link
Contributor

Yup - we'll get it done :)

@jonathanloos
Copy link
Author

@AllanJard do you have an estimated timeline for the fix? Don't mean to push, just trying to plan around this blocker.

@AllanJard
Copy link
Contributor

We'll hopefully get the changes made today, but actually tagging and releasing everything might take a little while as this would be the only change.

@AllanJard
Copy link
Contributor

That's it done (for example).

Was we tag up new releases these will progress through. Until then, an npm install or update should be bringing in the latest versions (unless you have a lock file restricting it to an older version).

@jonathanloos
Copy link
Author

Great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants