Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract NavigationTrackingStrategy as separate module #1669

Open
joshskeen opened this issue Oct 11, 2023 · 3 comments
Open

Extract NavigationTrackingStrategy as separate module #1669

joshskeen opened this issue Oct 11, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@joshskeen
Copy link

Are you requesting automatic instrumentation for a framework or library? Please describe.
NA

Is your feature request related to a problem? Please describe.
Yes. We do not ship androidx.navigation with our project, nor do we want to.
Instead, it would be best if we could choose whether to include androidx.navigation as a dependency in our project by
using dd-sdk-android:rum.

Describe the solution you'd like
Extract NavigationTrackingStrategy to a separate, new module, that can be selectively included in a project. For projects that do not use androidx.navigation, they no longer needlessly include this dependency.

@joshskeen joshskeen added the enhancement New feature or request label Oct 11, 2023
@0xnm
Copy link
Contributor

0xnm commented Oct 12, 2023

Hello @joshskeen! Can we please share more details about your concern: is it a blocker for you at the current stage and what is the issue behind - is it final binary size / number of methods in the binary?

While NavigationTrackingStrategy can indeed be extracted into the dedicated package, there are still some parts of the code in the RUM module which are using classes from androidx.navigation for the internal needs.

@joshskeen
Copy link
Author

Hi @0xnm. There are several reasons. Binary size is definitely one. The other is that our project in no way is using androidx.navigation and introducing androidx.navigation transitively is not desired. While it isn't blocking us, it would be more ideal if we had the option to exclude (and without breaking rum).

@0xnm
Copy link
Contributor

0xnm commented Oct 16, 2023

Hello @joshskeen. Thanks for the details provided, we will discuss this possibility with the team.

Meanwhile, I would like to say that we are also publishing statistics on the transitive dependencies usage, and androidx.navigation group brings the following artifacts with relatively small footprint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants