Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CSV dialects in CLI #225

Open
alexshpilkin opened this issue May 9, 2019 · 2 comments
Open

Support CSV dialects in CLI #225

alexshpilkin opened this issue May 9, 2019 · 2 comments

Comments

@alexshpilkin
Copy link

The library supports specifying a CSV dialect (e.g. TSV), and so does the CSVW spec in more or less the same manner, but the command-line tool doesn’t pick up this info. Why not?

[Note that there are some minimal changes in the CSVW spec compared to CSVDDF—e.g. lineTerminators (may be a string or array of strings) not lineTerminator. I’d be OK even with a CSVDDF-equivalent subset.]

@markus-oehme-pg40
Copy link

markus-oehme-pg40 commented Oct 13, 2021

The CLI actually complains about a valid CSVW metadata json descriptor containing a dialect property with

1. invalid_property. dialect: {...}

@markus-oehme-pg40
Copy link

Ah, this seems to be a bit more nuanced: the CLI only complains if the lineTerminators attribute is a string (which is valid according to CSVW), but not if it is an array of strings (which is also valid according to CSVW). The error message however is rather unhelpful.

So this causes the error:

        "lineTerminators": "\r\n",

and this works fine:

        "lineTerminators": ["\r\n"],

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants