Skip to content
This repository has been archived by the owner on Sep 8, 2021. It is now read-only.

Community & collection HTML aren't properly escaped server side #152

Open
artlowel opened this issue Jun 10, 2016 · 0 comments
Open

Community & collection HTML aren't properly escaped server side #152

artlowel opened this issue Jun 10, 2016 · 0 comments
Labels

Comments

@artlowel
Copy link
Contributor

artlowel commented Jun 10, 2016

Communities and collections have multiple fields that can contain HTML (introductory text, copyright, etc). These fields are rendered in our prototype using angular's built in innerHTML binding.

For some reason, only on the server side, it uses innerHTML not only as the content, but also adds it as an attribute to the wrapping tag. The attribute doesn't get escaped, and so if the HTML field contains a quote for example, it will break the page's rendering.

On the client-side rendered pages this issue doesn't occur

I don't think we should try to fix this ourselves, but rather wait until it is fixed in angular.

@artlowel artlowel added the bug label Jun 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant