Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dwcCatalogNumber #134

Open
cgendreau opened this issue Mar 17, 2022 · 2 comments
Open

Remove dwcCatalogNumber #134

cgendreau opened this issue Mar 17, 2022 · 2 comments

Comments

@cgendreau
Copy link
Collaborator

dwcCatalogNumber is replaced by materialSampleName since some material sample don't have a catalogNumber.
@dshorthouse
Copy link
Contributor

So, you've eliminated dwcCatalogNumber but kept dwcOtherCatalogNumbers? Would it not make sense then to call the latter, otherMaterialSampleNames to better correspond with this change?

@cgendreau
Copy link
Collaborator Author

Yes, it should remain consistent but it doesn't imply the same amount of work on the implementation side so it will be done in 2 stages (if we proceed, this is a ticket, nothing is actually eliminated yet).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dshorthouse @cgendreau