Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

English word in the French version of UMIL #160

Open
fujinaga opened this issue Oct 1, 2024 · 2 comments · May be fixed by #164
Open

English word in the French version of UMIL #160

fujinaga opened this issue Oct 1, 2024 · 2 comments · May be fixed by #164
Assignees
@kunfang98927 @kyrieb-ekat @JoyfulGen
Labels
priority: high

Comments

@fujinaga
Copy link
Member

fujinaga commented Oct 1, 2024

Horbostel-Sachs box in the Instruments page, the French version says: "Unclassifed".
Shouldn't it be changed to Non classifié ?

image
@JoyfulGen
Copy link

I think "non classifié" is good! Although perhaps the plural "Non classifiés" might be better, supposing there will be more than one unclassified instrument?

@fujinaga
Copy link
Member Author

fujinaga commented Oct 4, 2024

Yes, let’s change it to “Non classifiés”. Thank you, @JoyfulGen !

kunfang98927 added a commit that referenced this issue Oct 4, 2024
@kunfang98927
fix: add "description" & "alias" fields into InstrumentName model
6c04418 
- add "description" & "alias" fields into InstrumentName model;
- fix "Non classifiés" in facet search;
- support only English and French in facet search;
- fix a bug: replace `active_language.en_label == "french"` with `... "French"`;

Refs: #160 #161
@kunfang98927 kunfang98927 linked a pull request Oct 11, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kunfang98927 kunfang98927

@kyrieb-ekat kyrieb-ekat

@JoyfulGen JoyfulGen

Labels
priority: high
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support "Add new instrument name"; Initialize "Upload image"; DDMAL/VIM
4 participants
@fujinaga @kunfang98927 @kyrieb-ekat @JoyfulGen