Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serum vst parameter changed in ui but was not applied #205

Open
PabloZimmermann opened this issue Aug 16, 2024 · 0 comments
Open

serum vst parameter changed in ui but was not applied #205

PabloZimmermann opened this issue Aug 16, 2024 · 0 comments

Comments

@PabloZimmermann
Copy link

Hi, first of all, thanks for this amazing library!

The set_parameter updated successfully the UI but the effect is not applied to the audio.

@DBraun reported something similar a while ago #149 (comment)

but he said that the issue was due to "having a MIDI note longer than my record duration..." i don't see how this applies to my case, or does it? help!

my env:
mac m1
sonoma 14.4.1
Python 3.10.10
dawdreamer: 0.8.0

A) testing the effect with a preset that uses the set_parameter to activate the phaser effect

code:


from IPython.display import Audio
import dawdreamer as daw

SAMPLE_RATE = 44100
BUFFER_SIZE = 512
SERUM_PATH = "/Library/Audio/Plug-Ins/vst/Serum.vst"
PRESET_WITHOUT_EFFECTS = "presets/preset_1_no_phaser.fxp"
engine = daw.RenderEngine(SAMPLE_RATE, BUFFER_SIZE)
serum = engine.make_plugin_processor("serum", SERUM_PATH)
serum.load_preset(PRESET_WITHOUT_EFFECTS)
serum.set_parameter(156,1) # enable the phaser
serum.set_parameter(111,1) # rate to max, to make the effect very evident! wet is already 1.0 by default.
serum.open_editor() # VERIFY THAT THE EFFECTS DID CHANGE CORRECTLY IN THE UI
serum.add_midi_note(60, 100, 0.1, 0.5, beats=True) # CREATE A ONE SHOT NOTE
engine.load_graph([(serum, [])])
engine.render(5)
audio = engine.get_audio()
Audio(audio, rate=SAMPLE_RATE) 

B) testing the effect with a preset that already has the effect applied and the set_parameter is not used:

SAMPLE_RATE = 44100
BUFFER_SIZE = 512
SERUM_PATH = "/Library/Audio/Plug-Ins/vst/Serum.vst"
PRESET_WITH_EFFECTS = "presets/preset_2_with_phaser.fxp"
engine = daw.RenderEngine(SAMPLE_RATE, BUFFER_SIZE)
serum = engine.make_plugin_processor("serum", SERUM_PATH)
serum.load_preset(PRESET_WITH_EFFECTS)
serum.open_editor() # VERIFY  THE EFFECTS IS ENABLED
serum.add_midi_note(60, 100, 0.1, 0.5, beats=True) # CREATE A ONE SHOT NOTE
engine.load_graph([(serum, [])])
engine.render(5)
audio = engine.get_audio()
Audio(audio, rate=SAMPLE_RATE) 

RESULT: as expected the effect is successfully audible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant