Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update env to add geemap, gh and is2view #77

Merged
merged 5 commits into from
Jul 28, 2023
Merged

Update env to add geemap, gh and is2view #77

merged 5 commits into from
Jul 28, 2023

Conversation

tsnow03
Copy link
Member

@tsnow03 tsnow03 commented Jul 28, 2023

No description provided.

@github-actions
Copy link

Binder 👈 Test this PR on Binder

@tsnow03
Copy link
Member Author

tsnow03 commented Jul 28, 2023

/condalock

@tsnow03 tsnow03 requested a review from scottyhq July 28, 2023 17:44
weiji14
weiji14 reviewed Jul 28, 2023
View reviewed changes
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions to follow the compatibility release spec ~= as per #46. Shouldn't need to relock the conda-lock file afterwards unless the versions have changd in <1 hour.

environment.yml Outdated Show resolved Hide resolved
environment.yml Outdated Show resolved Hide resolved
@tsnow03 tsnow03 requested a review from weiji14 July 28, 2023 21:48
@weiji14
Copy link
Member

weiji14 commented Jul 28, 2023

@tsutterley requested that we add https://anaconda.org/conda-forge/is2view to the hub-image, ok if I do it in this PR too @tsnow03?

@tsnow03
Copy link
Member Author

tsnow03 commented Jul 28, 2023

Yes! Thanks @weiji14

@weiji14 weiji14 changed the title Update env for geemap Update env to add geemap, gh and is2view Jul 28, 2023
@weiji14
Copy link
Member

weiji14 commented Jul 28, 2023

/condalock

weiji14
weiji14 approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ok to merge once the tests pass. 🚀

@tsnow03 tsnow03 merged commit a5fd4b6 into main Jul 28, 2023
1 check passed
@tsnow03 tsnow03 deleted the geemap branch July 28, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiji14 weiji14 weiji14 approved these changes

@scottyhq scottyhq Awaiting requested review from scottyhq

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tsnow03 @weiji14 @actions-bot