Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add itslive #72

Merged
merged 5 commits into from
Jul 27, 2023
Merged

Add itslive #72

merged 5 commits into from
Jul 27, 2023

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Jul 18, 2023

Python client for ITSLIVE glacier velocity data! Repo at https://github.com/nasa-jpl/itslive-py

Closes #71, cc @betolink

@weiji14
Add itslive
69e9e3a 
Python client for ITSLIVE glacier velocity data! Repo at https://github.com/nasa-jpl/itslive-py
@weiji14 weiji14 self-assigned this Jul 18, 2023
@github-actions
Copy link

Binder 👈 Test this PR on Binder

@weiji14
Copy link
Member Author

weiji14 commented Jul 18, 2023

/condalock

@weiji14
Bump earthaccess from 0.5.1 to 0.5.2, pin pandas from 1.5.2 to 1.5.1
5a52a44 
The itslive=0.2.0 package requires earthaccess>=0.5.2 and pandas=1.5.1.
@weiji14
Copy link
Member Author

weiji14 commented Jul 18, 2023

/condalock

weiji14
weiji14 commented Jul 18, 2023
View reviewed changes
environment.yml
@@ -48,7 +48,7 @@ dependencies:
- networkx==2.8.8
- numba==0.56.4 # high-performance numerics
- numpy==1.23.5
- pandas==1.5.2
- pandas~=1.5.1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@betolink, there's a strict pinning on itslive to pandas==1.5.1 at https://github.com/nasa-jpl/itslive-py/blob/2672896a1c09b21c00a11b587c0d558372b6aaf9/pyproject.toml#L20. Is that intended, or should it be pandas>=1.5.1 instead?

@weiji14 weiji14 marked this pull request as ready for review July 18, 2023 23:07
@weiji14 weiji14 requested a review from betolink July 18, 2023 23:26
@weiji14 weiji14 mentioned this pull request Jul 18, 2023
Merged
@weiji14
Copy link
Member Author

weiji14 commented Jul 27, 2023

/condalock

@weiji14
Copy link
Member Author

weiji14 commented Jul 27, 2023

Will merge this in once the tests pass, let me know @betolink once you've updated itslive-py to a new version and I can push a patch update.

@weiji14 weiji14 merged commit e563a8c into main Jul 27, 2023
1 check passed
@weiji14 weiji14 deleted the add-itslive branch July 27, 2023 02:33
@betolink
Copy link
Member

Thanks @weiji14 ! I think the pining was just to keep the dependencies in sync but yes it should be >= I'll be working on a new version for next week that should come with the patch. I wonder this is the second library where I change the original name and looks like that breaks the conda-forge bots, I didn;t see the automatic PRs. Next time I should stick to the original name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betolink betolink Awaiting requested review from betolink

Assignees

@weiji14 weiji14

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ITS_LIVE python library
3 participants
@weiji14 @betolink @actions-bot