Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pinned version of nbconvert has problems with HTML blocks in markdown #116

Closed
itcarroll opened this issue Jun 12, 2024 · 1 comment · Fixed by #117
Closed

pinned version of nbconvert has problems with HTML blocks in markdown #116

itcarroll opened this issue Jun 12, 2024 · 1 comment · Fixed by #117

Comments

@itcarroll
Copy link

The nbconvert package is pinned to version 6.5.3:

- nbconvert==6.5.3

As a result, the mistune package version is ... quite outdated.

As a result, certain markdown content (particularly HTML blocks) does not get converted to HTML correctly.

Can nbconvert be unpinned? I don't see a reason it is pinned, and in NASA-Openscapes hub it is not present at all (comes in from jupyter-server, I think.). I've just tried a conda update -n notebook -c conda-forge --all and it happily upgrades nbconvert to "7.16.4". And the upgrade solves my markdown rendering problem.

@weiji14
Copy link
Member

weiji14 commented Jun 15, 2024

Hi @itcarroll, I've opened up a PR at #117 to upgrade nbconvert to 7.16.4. See if that looks ok and we can merge that in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants