Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magento-deploy-ignore not ignoring folders/files #67

Open
proxium opened this issue Sep 11, 2015 · 6 comments
Open

magento-deploy-ignore not ignoring folders/files #67

proxium opened this issue Sep 11, 2015 · 6 comments

Comments

@proxium
Copy link

proxium commented Sep 11, 2015

As @AydinHassan suggested, this is an update:

I'm using "magento-hackathon/magento-composer-installer": "3.0.5" and none of these solved the problem.

  • Using package name

        "magento-deploy-ignore": {
            "kirchbergerknorr/magento": ["/skin/frontend/base/default/favicon.ico"],
            "kirchbergerknorr/magento": ["/downloader/"]
        },
    
  • Using asterisk

        "magento-deploy-ignore": {
            "*": ["/skin/frontend/base/default/favicon.ico"],
            "*": ["/downloader/"]
        },
    
  • Removing leading slash

        "magento-deploy-ignore": {
            "kirchbergerknorr/magento": ["skin/frontend/base/default/favicon.ico"],
            "kirchbergerknorr/magento": ["downloader/"]
        },
    
@cs-digitalpatrioten
Copy link

cs-digitalpatrioten commented Oct 7, 2016

Works:

"magento-deploy-ignore": { "test/module": [ "/app/locale/de_DE/Test_Module.csv", "/app/locale/es_ES/Test_Module.csv" ], "test/module2": [ "/app/locale/de_DE/Test_Module2.csv", "/app/locale/de_AT/Test_Module2.csv" ] }

@proxium
Copy link
Author

proxium commented Oct 13, 2016

Now I'm using "magento-hakathon/magento-composer-installer":"3.0.7"
and I'm still not able to ignore those two resources (favicon.ico and /downloader/ folder)

Here is the used syntax:

 "extra": {
        "magento-root-dir": "src/",
        "with-bootstrap-patch": false,
        "skip-suggest-repositories": true,
        "auto-append-gitignore": true,
        "magento-deploystrategy": "copy",
        "magento-force": true,
        "magento-deploy-sort-priority": {
            "firegento/magento": "100"
        },
        "magento-deploy-ignore": {
            "firegento/magento": ["/skin/frontend/base/default/favicon.ico"],
            "firegento/magento": ["/downloader/"]
        }
    }

@AydinHassan
Copy link
Contributor

@proxium firegento/magento is not a magento module - this plugin does not touch that package at all as it's type is magento-core not magento-module.

@proxium
Copy link
Author

proxium commented Feb 23, 2017

@krombox
Copy link

krombox commented Nov 15, 2017

Same problem. "magento-hackathon/magento-composer-installer": "3.1.2".
"magento-deploy-ignore": { "*": ["/.htaccess"], "magento/core": ["/.htacces"] }

File still overrides

@Flyingmana
Copy link
Contributor

@krombox the installer can sadly only ignore files, which come from magento modules.
if its source is a magento core project, then it is not handling the deploy, and therefore cant ignore it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants