Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up object size usage #644

Open
martinkilbinger opened this issue Jul 20, 2023 · 1 comment
Open

Clean up object size usage #644

martinkilbinger opened this issue Jul 20, 2023 · 1 comment
Assignees
Labels

Comments

@martinkilbinger
Copy link
Contributor

Various estimators of object size are used throughout the code:

  • fwhm
  • sigma (e.g. from HSM moment measurement)
  • T = I_xx + I_yy (sum of second-order moments), also written as R^2, T approx 2 sigma^2

Units can be in pixels or arcsec/arcmin.

These should be unified and made clear.

Two functions to transform between some of those exist in sp_validation/galaxy.py, we should use and extend those.

In the code, replace hard-coded numbers 1.17741, 2.355.

@sfarrens
Copy link
Member

sfarrens commented Nov 8, 2023

Tagging @lbaumo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants