Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Loaded event not firing for views in popups #1363

Closed
2 tasks done
mattleibow opened this issue Aug 23, 2023 · 5 comments
Closed
2 tasks done

[BUG] Loaded event not firing for views in popups #1363

mattleibow opened this issue Aug 23, 2023 · 5 comments
Labels
area/views Issue/Discussion/PR that has to do with Views bug Something isn't working unverified

Comments

@mattleibow
Copy link

mattleibow commented Aug 23, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Did you read the "Reporting a bug" section on Contributing file?

Current Behavior

When I subscribe to the Loaded event on my view, it does not fire

Expected Behavior

The Loaded event fires

Steps To Reproduce

  1. Clone the repro here [BUG] SKLottieView not working in Popup mono/SkiaSharp.Extended#142
  2. Run the app and observe no playing animations
  3. Attach a handler to Loaded on the lottie views
  4. Run and observe the Loaded event fires for the views in the main page but not the popup

Link to public reproduction project repository

mono/SkiaSharp.Extended#142

Environment

- .NET MAUI CommunityToolkit:
- OS: Mac Catalyst and IOS but also reports on Android
- .NET MAUI:

Anything else?

No response

@mattleibow mattleibow added bug Something isn't working unverified labels Aug 23, 2023
@mattleibow
Copy link
Author

Could it be related to #1342?

@pictos
Copy link
Member

pictos commented Aug 23, 2023

@mattleibow does this happen on all platforms or just iOS?

@cat0363
Copy link
Contributor

cat0363 commented Aug 25, 2023

Some of the PRs I'm in charge of have not been merged into main, but I verified it with the latest source code I have.

[Android] [iOS] [Windows]
Android.Emulator.-.pixel_2_-_api_30_5554.2023-08-25.14-27-13.mp4
iPhone.14.iOS.16.4.2023-08-25.14-34-44.mp4
2023-08-25.14-36-34.mp4

Only iOS stops at the first frame.
Android and Windows seem to be working fine at least.

@vhugogarcia vhugogarcia added the area/views Issue/Discussion/PR that has to do with Views label Dec 7, 2023
@cat0363
Copy link
Contributor

cat0363 commented Jan 22, 2024

The problem did not reproduce on .NET 8.
Below are the verification results.

[Android] [iOS] [Windows]
Android.Emulator.-.pixel_2_-_api_30_5554.2024-01-22.09-18-14.mp4
iPhone.15.iOS.17.0.2024-01-22.09-24-26.mp4
2024-01-22.09-04-46.mp4

I used the following versions:
Community Toolkit 7.0.1
SkiaSharp.Extended.UI.Maui 2.0.0-preview.86

The problem occurs when using the .NET 7 version of MAUI, but not the .NET 8 version.

@bijington
Copy link
Contributor

Amazing work again @cat0363 thank you. I'll close this issue down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/views Issue/Discussion/PR that has to do with Views bug Something isn't working unverified
Projects
None yet
Development

No branches or pull requests

5 participants