Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Conflict with Manager when switching new blank workflows using shortcuts #1130

Open
LukeG89 opened this issue Oct 6, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@LukeG89
Copy link

LukeG89 commented Oct 6, 2024

Frontend Version

1.3.9

Expected Behavior

No conflicts when switching new blank workflows created with the "+" button.

Actual Behavior

When you switch new blank workflow tabs using shortcuts, there is a conflict when you try to reach the latest workflow and when you try to switch from the first one to the last one.

This is a really specific issue because with default and template workflows doesn't happen, neither if you create new blank workflows through the shortcut.
It only happens with the "+" button in Workflows tab.

plus_button

In the conflict you can see rgthree mentioned, but if I disable it the problem remains.
If I keep rgthree enabled and disable only the Manager, the problem is gone.

Steps to Reproduce

  • Create some workflows with the "+" button in Workflows tab
  • Switch workflow tabs using shortcuts
Switch_Blank_Workflows.mp4

Debug Logs

No errors.

Browser Logs

components-manager.js:740 Uncaught (in promise) TypeError: Cannot read properties of null (reading 'extra')
at app.loadGraphData (components-manager.js:740:29)
at app.loadGraphData (rgthree.js:573:51)
at Proxy.load (workflows.ts:243:30)
at loadOpenedWorkflowIndexShift (workflowStore.ts:52:28)
at Proxy.loadNextOpenedWorkflow (workflowStore.ts:58:11)
at Proxy.wrappedAction (pinia.mjs:1405:26)
at function (commandStore.ts:306:28)
at errorHooks.ts:34:22
at Proxy.execute (commandStore.ts:332:70)
at Proxy.wrappedAction (pinia.mjs:1405:26)

What browsers do you use to access the UI ?

Google Chrome

Other

No response

@LukeG89 LukeG89 added the Potential Bug Untriaged bug label Oct 6, 2024
@LukeG89
Copy link
Author

LukeG89 commented Oct 6, 2024

Update: It happens both creating with the "+" button and with shortcut. The shortcut one specifically when you try to switch from an existing workflow to the new blank one.

@huchenlei huchenlei added bug Something isn't working and removed Potential Bug Untriaged bug labels Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants