Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set up cb-csv demo #41

Open
evanwill opened this issue Feb 11, 2023 · 3 comments
Open

set up cb-csv demo #41

evanwill opened this issue Feb 11, 2023 · 3 comments

Comments

@evanwill
Copy link
Contributor

requires github action, which I don't really want in the main branch of the repository (because it causes weird issues from people copying it). So probably need to set up a separate demo project repository?

@maehr
Copy link
Contributor

maehr commented Apr 14, 2023

I would try to keep it in one repo. I have really good experiences with GH actions that deploy to a separate branch (probably also as gh-page). A quick fix could be Cloudflare Pages, Vercel et. al.

@evanwill
Copy link
Contributor Author

evanwill commented Apr 17, 2023

@maehr as far as I know, gh action workflows (i.e. the yml file ".github/workflows/example.yml") have to be in the default branch to run (even if they are using other branches)? That has tended to cause issues and confusion when people make a copy with "use this template", since they end up with an action running in their own repo that results in a broken site or build errors (because it isn't configured correctly for their repo).
The third party build option from a demo-site branch might be best option. We have mostly used Render, but could check out the other services too.

@maehr
Copy link
Contributor

maehr commented Apr 17, 2023

I agree with you. The third party option is the cleanest and simplest solution. Alternatively, you could create a GH Action.github/workflows/demosite.yaml that only runs on the demosite-branch

on:
  push:
    branches:
      - demosite
 
(...)

The YAML file is still visible, but it does not trigger Actions when you use the repo as a template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants