Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow MappingGenerator to keep the same name for method bridges #800

Open
Col-E opened this issue Jun 3, 2024 · 0 comments
Open

Allow MappingGenerator to keep the same name for method bridges #800

Col-E opened this issue Jun 3, 2024 · 0 comments

Comments

@Col-E
Copy link
Owner

Col-E commented Jun 3, 2024

Rough idea given the following model:

abstract class Base<T extends Foo> {
  abstract void accept(T input);
}

class Impl extends Base<FooImpl> {
  void accept(FooImpl input); // becomes bridge to method with signature from parent xlass
  
  // void accept(Foo input); // Method implementation goes here in actuality
}

Currently the mapping generator will see the two methods in Impl as having different signatures and will thus allow the passed NameGenerator to create unique names for each. For keeping things pretty in the decompiler output, it would be nice if we could have these bridge methods share the same name as the real method taking on the parent method's signature.

I think having a generic system to track "this method is a bridge to this method" would be nice, which once completed could be plugged into the MappingGenerator code with ease.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant