Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow changing of the download file name #12

Open
niccokunzmann opened this issue Jan 15, 2017 · 6 comments
Open

Allow changing of the download file name #12

niccokunzmann opened this issue Jan 15, 2017 · 6 comments

Comments

@niccokunzmann
Copy link
Member

The downloaded file name can be changed. The path is

/download/<build-id>/<file-name>

Thus, we can safely allow the changing of the file name to be done in the web front end.

@svasquez
Copy link

Hi, how can I contribute?

@niccokunzmann
Copy link
Member Author

niccokunzmann commented Feb 17, 2017

Hi, if you like, you can solve this issue or choose any issue of your liking or create issues yourself and I help you solve them.

For this issue, you can change the last component of the download url - which is the file name.
This can be done in installing.html, since this is where we can download the image.
The idea: people may want to download the file with the date in the name or have it named after some purpose, like "programming-club-2017-02-17.iso".

What are your thoughts, @svasquez?

@niccokunzmann niccokunzmann changed the title Allow chaning of the download file name Allow changing of the download file name Feb 17, 2017
@svasquez
Copy link

svasquez commented Feb 17, 2017

Do you have some contribute guide? Because, I don't have experience with GitHub and pull request. But I want to learn.

@niccokunzmann
Copy link
Member Author

Here is a list of git tutorials:
https://github.com/fossasia/flappy-svg/tree/master/tasks/learn_git

You can also join the chat on FOSSASIA slack: http://fossasia-slack.herokuapp.com/ I am also @niccokunzmann there.

@niccokunzmann
Copy link
Member Author

niccokunzmann commented Feb 17, 2017

https://try.github.io/ is a nice git tutorial for all git commands. Knowing them is a nice addition to the desktop client. However, it does not cover pull-requests.

If you like to create your first pull-request, you can create a contributing.md. The idea behind the file is to guide new contributors to how to contribute to the project. You are perfectly fir to write down notes there. You can create the file like this:

  1. go to https://github.com/CodersOS/create
  2. click "create new file" and create the file contributing.md, write something and commit
  3. This leads you to the pull-request.
  4. You create a pull-request and I see it

When you created the pull-request, post the link here, so I can check back with you.
If you have any troubles, you can post screenshots here or in the slack chat and we can help.

How would you like to go on, @svasquez?

@svasquez
Copy link

Thanks, @niccokunzmann for the info. I fork the repo, so I going to see the project to understand it. After, that, I will create the contributing.md and solve this issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants