Neve Options page can not be accessed by non super admin users on multisite network

[rodica-andronache]

Description

Right now, accessing Neve Options page is not accessible for admins ( without super admin role ), meaning that those admins also don't have access to Neve Pro options once the plugin is installed https://vertis.d.pr/i/fkQpDM

Moved from #4034

Step-by-step reproduction instructions

1. Install the Neve theme on a WordPress multisite installation.
2. Create multiple sites and grant administrator access to different users.
3. Attempt to access the Neve Options page on one of the sites using the administrator credentials. => this is not possible right now

Screenshots, screen recording, code snippet or Help Scout ticket

No response

Environment info

No response

Is the issue you are reporting a regression

No

[cristian-ungureanu]

@HardeepAsrani, Bogdan pretty much summarized this issue here but since we proceed in another way in this issue, I want to better clarify this for each case so please let me know your thoughts regarding the following:

1. Plugins tab, hide the whole tab or disable the buttons?
   

2. Starter Sites tab when Neve Pro is not active, hide the whole tab or disable the install button?
   

3. For this one, I assume that we can do the "Ask admin to install" thing, right?
   

4. What about starter sites? Should we still hide them or allow them but block the import button?

[HardeepAsrani]

Hey @cristian-ungureanu,

I'd go with having "Ask your super-admin to install" case in each of these situations if that doesn't cause big issue with translation count.

I'll loop in @vytisbulkevicius if he has any thoughts regarding this.

[rodica-andronache]

@cristian-ungureanu
Neve:

• “If the super admin enables the plugins in the administration menu the admin should be able to activate a plugin but not install one.” This does not work for me. With the Enable administration menus option on https://vertis.d.pr/i/YoeGZA, in the About us page, the admin can’t activate the plugins https://vertis.d.pr/i/PY76PD (plugins which are not Network Activated)

• If the super admin enables the plugins in the administration menu in the Neve Options page > Plugins tab , the admin sees a Deactivate button for plugins that are activated. But that button doesn’t work well for plugins which are Network activated. In that case, it looks like you are deactivating the plugin, but after you refresh the page, you get the Deactivate button again. https://vertis.d.pr/v/L5XBYh

Neve Pro:

• In the Neve Pro tab, when you click on Install and activate Otter Blocks PRO , the notice is quite large, not sure if it can be made smaller maybe https://vertis.d.pr/v/EGz31F

• In the Neve Pro tab there are some links for EDD and Lifter which go to a page that can’t be accessed by admins. I think the link could be hidden in those cases, to have just the message there in that case https://vertis.d.pr/v/hwEdi4

[cristian-ungureanu]

@rodica-andronache thanks for testing this.

1. That's expected. To make things easier, a plugin can be activated in Neve admin if it's available and can be activated from Dashboard -> Plugins.
2. Fixed
3. Fixed. There you should not be able to click on that button if Otter and Otter Pro are not at least installed.
4. Fixed.

I will ask Hardeep to review the changes and then I'll need another look from QA.

[rodica-andronache]

@cristian-ungureanu

Neve

• In the About us page there is a tab for Otter Blocks with two install buttons for it, which I think should be disabled for Admins (not superadmins), with the same message as the other install buttons (that you can ask your admin to install it) https://vertis.d.pr/i/LLXn49

• Regarding:

“If the super admin enables the plugins in the administration menu the admin should be able to activate a plugin but not install one.” This does not work for me. With the Enable administration menus option on https://vertis.d.pr/i/YoeGZA, in the About us page, the admin can’t activate the plugins https://vertis.d.pr/i/PY76PD (plugins which are not Network Activated)

You said “That's expected. To make things easier, a plugin can be activated in Neve admin if it's available and can be activated from Dashboard -> Plugins.
”

In my case, the admin(not superadmin) can activate/deactivate plugins from Dashboard -> Plugins but can’t do the same in Neve > About us. Let me know if I'm missing anything. Thank you! https://www.loom.com/share/f459223eef384a8688c97bd980376ded?sid=ebac4122-2605-453c-9bc0-30c82a17229a

Neve PRO

• When Otter and Otter PRO are installed but not activated https://vertis.d.pr/i/kAOjI6 and I am the superadmin I still see this button https://vertis.d.pr/i/EdOSil and nothing happens when I click on it.

[cristian-ungureanu]

Hey @rodica-andronache, thank you very much for testing this again.

• For the first two problems we have a separate issue. The About Us page is part of the SDK and is visible on every product. Those two problems should be handled here: [SDK] Install/activate plugins from the About page by non super admin users on multisite network #4071
• I've managed to fix the other one with the Otter install button. Please have a look and let me know if it's working now.

Last, I would like to ask if it's possible to post PR issues in the PR thread as we did before, and not in the issue thread. I think it's a good practice and can help us in the future when we need to go back and see why a particular thing was done in one way or another.

Thank you!

[rodica-andronache]

@cristian-ungureanu sure, I'll post on the PR from now on, thanks for letting me know 👍

[pirate-bot]

🎉 This issue has been resolved in version 3.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀