Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeScript type definitions #93

Open
neilzo opened this issue Jun 8, 2021 · 0 comments
Open

Add TypeScript type definitions #93

neilzo opened this issue Jun 8, 2021 · 0 comments
Labels
status: accepting prs If you can resolve this issue, please send a PR! type: cleanup Technical debt, testing, or similar improvements

Comments

@neilzo
Copy link
Collaborator

neilzo commented Jun 8, 2021

We've duplicated a type definition for this repo a few times now:

To DRY things up, we should add this definition to this repo.

The type def we've used (at time of this issue creation) is:

declare module '40phaser' {
  export type LaunchOptions = {
    phaser?: typeof Phaser;
    phaserOptions: {
      parent?: string;
    };
  };

  export const launch40Phaser: (options: LaunchOptions) => void;
}
@neilzo neilzo added status: accepting prs If you can resolve this issue, please send a PR! type: cleanup Technical debt, testing, or similar improvements labels Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepting prs If you can resolve this issue, please send a PR! type: cleanup Technical debt, testing, or similar improvements
Projects
None yet
Development

No branches or pull requests

1 participant