Add hunger when hit + Fix issue where hunger would go down despite hunger being disabled #1859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After further experimentation. This is not a full fix and in some cases, hunger will still fall. For that reason, I am closing this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1857
Currently, if you disable food and attack another player, their hunger will go down despite food being disabled. The server does not send any attributes to the client from what I have seen. However, this PR solves this issue by resending their hunger if food is disabled and the server decides that they need to take hunger.
Additionally, according to https://minecraft.gamepedia.com/Hunger#Exhaustion_level_increase
Food is reduced when attacked which I also implemented.