Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0] Unimplemented Daylight Detector block entity #11

Open
3 tasks done
squeeglii opened this issue Apr 11, 2020 · 3 comments
Open
3 tasks done

[2.0] Unimplemented Daylight Detector block entity #11

squeeglii opened this issue Apr 11, 2020 · 3 comments

Comments

@squeeglii
Copy link
Contributor

squeeglii commented Apr 11, 2020

Expected Behavior

The Java 1.12.2 world is expected to convert and then run on the server. If there was a problem with the world file, surely it could have some meaningful error to an end-user or (if it was a specific block) the offender could be removed during conversion.

Actual Behavior

I've only run into this crash on this specific world so it's a minor issue. Forge has been used with this world, however, it has only ever had worldedit on it, thus it shouldn't be an issue with modded blocks or entities.

The server logs the chunks being converted and such and then it just exits without any information. Checking the latest log, it reveals an IllegalStateException caused by a NullPointerException (Thrown by a checknotnull).

Starting the server again, it begins to try to convert the level again, failing every time.

Steps to Reproduce

Load the attached world below onto a server and start the server.

Crashdump, Backtrace or Other Files

Checklist:

  • I made sure there aren't duplicates of this report (Use Search)
  • I made sure I am using an up-to-date version of Nukkit
  • I Made sure the bug/error is not caused by a plugin

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@Extollite
Copy link
Contributor

Extollite commented Apr 11, 2020

It's not working because NukkitX 2.0 has no implemented DaylightDetectors, if you really want to use this map try to use mcctoolchest and delete them.

@SupremeMortal
Copy link
Member

SupremeMortal commented Apr 11, 2020

We should at least implement the base daylight detector block entity so that the world can be loaded without an error.

@squeeglii squeeglii changed the title [2.0] A Specific 1.12 Java World (after conversion) crash [2.0] Unimplemented Daylight Detector block entity Apr 12, 2020
@squeeglii
Copy link
Contributor Author

So we decided to worldedit all the daylight sensors away for the time being, however, we're still running into the exact same error. I did an MCEdit analysis and we now only have these tile entities:
analysis

world
log

SupremeMortal referenced this issue in CloudburstMC/Nukkit Apr 17, 2020
* Add DaylightDetector block entity

* Removed saveAdditionalData()

Co-authored-by: CiviledCode <[email protected]>
@GingerGeek GingerGeek transferred this issue from CloudburstMC/Nukkit Jul 3, 2020
Kazzuk pushed a commit that referenced this issue May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants