Open halo filling on Windowed fields #3834
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How does this PR address #3833 |
|
There was a missing offset that was preventing filling the open halos for windowed fields correctly |
Put a comment in the code on the key lines to prevent the problem from happening again. This PR only fixes the code but does not address the underlying issue that it's easy to miss the need for that. |
glwagner
reviewed
Oct 17, 2024
Comment on lines
+18
to
+22
| size = fill_halo_size(field, regular_fill, indices, boundary_conditions, loc, grid) | ||
| offset = fill_halo_offset(size, regular_fill, indices) | ||
| params = KernelParameters(size, offset) | ||
|
|
||
| launch!(arch, grid, params, open_fill, field, left_bc, right_bc, loc, grid, args) |
There was a problem hiding this comment.
It's hard for me to tell how what these changes do so a comment would help.
glwagner
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should close #3833. Probably, we can wait to merge #3792 before this one and add some tests for fill halo regions here