You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
1 ) Currently, domain- and language-specific site names are set to be overridden by the name of the domain. This has been done by exporting the variable domain_sitename_override=true to the Domains feature.
This means we can't have translatable site names like "City of Kada" <--> "Kadan kaupunki" because the site name and thus part of the page title is overridden to the name of the domain, "Kada.fi".
There doesn't seem to be a reason to enforce this setting across the whole platform; multilingual domain site names seem to be working just fine without the override setting enabled.
Thus, the domain_sitename_override variable should be removed from the Domains feature so changing the setting on KADA installations will not leave the feature unnecessarily overridden, as that would require a separate feature override to be generated for it for every separate installation.
2 ) Elsewhere in the code, hooks are used to override various titles, e.g. titles in http://www.turku.fi/term/77/rss.xml, and these hooks hardcode installation-dependent strings. See e.g. kada_export_feature_views_pre_render() in kada_export_feature.module.
Instead of replacing the hardcoded "Turku.fi" with a hardcoded dummy domain, we should use the multilingual domain variable site_name to construct titles.
Thus, to avoid having to override the same things at every installation, we need to refactor to remove hardcoding as in 2), which can be only be done after removing the override variable as detailed in 1).
But, is there something that's being overlooked here? Custom domain-handling code should be using domain machine names and never need to touch domain variables anyway, so things should be safe on that front.
The text was updated successfully, but these errors were encountered:
1 ) Currently, domain- and language-specific site names are set to be overridden by the name of the domain. This has been done by exporting the variable
domain_sitename_override=true
to the Domains feature.This means we can't have translatable site names like "City of Kada" <--> "Kadan kaupunki" because the site name and thus part of the page title is overridden to the name of the domain, "Kada.fi".
There doesn't seem to be a reason to enforce this setting across the whole platform; multilingual domain site names seem to be working just fine without the override setting enabled.
Thus, the
domain_sitename_override
variable should be removed from the Domains feature so changing the setting on KADA installations will not leave the feature unnecessarily overridden, as that would require a separate feature override to be generated for it for every separate installation.2 ) Elsewhere in the code, hooks are used to override various titles, e.g. titles in http://www.turku.fi/term/77/rss.xml, and these hooks hardcode installation-dependent strings. See e.g. kada_export_feature_views_pre_render() in kada_export_feature.module.
Instead of replacing the hardcoded "Turku.fi" with a hardcoded dummy domain, we should use the multilingual domain variable
site_name
to construct titles.Thus, to avoid having to override the same things at every installation, we need to refactor to remove hardcoding as in 2), which can be only be done after removing the override variable as detailed in 1).
But, is there something that's being overlooked here? Custom domain-handling code should be using domain machine names and never need to touch domain variables anyway, so things should be safe on that front.
The text was updated successfully, but these errors were encountered: