Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Custom Line Terminator Handling #760

Open
bd82 opened this issue Jun 21, 2018 · 0 comments
Open

Simplify Custom Line Terminator Handling #760

bd82 opened this issue Jun 21, 2018 · 0 comments
Labels

Comments

@bd82
Copy link
Member

bd82 commented Jun 21, 2018

The ILexerConfig requires two very similar properties to handle custom line terminators
https://sap.github.io/chevrotain/documentation/3_6_1/interfaces/ilexerconfig.html

With a breaking change we can probably only accept a list of strings or charCodes to be used as line terminators and compute the regExp automatically. So only one argument would have to be provided.

@bd82 bd82 added the API label Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant