Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification and Proposal to Utilize HealthCheckUrl #48

Open
kylepmanuel opened this issue Sep 10, 2024 · 1 comment
Open

Clarification and Proposal to Utilize HealthCheckUrl #48

kylepmanuel opened this issue Sep 10, 2024 · 1 comment

Comments

@kylepmanuel
Copy link

I noticed that the HealthCheckUrl property exists in the configuration but currently seems to be only set and not used. Could you clarify its intended purpose? If the URL is a legacy field or there are no updates planned for its use, I would like to propose the following changes:

  1. AddGotenbergHealthCheck: A service collection extension method that integrates with the standard ASP.NET Core health check framework.
  2. Optional Pre-Check in GotenbergSharpClient: Add an optional method on GotenbergSharpClient to perform a health pre-check against the HealthCheckUrl before sending any requests. This method will be available for developers to call as needed.

If allowed, I would be happy to implement and submit a pull request for these changes.

@Jaben
Copy link
Member

Jaben commented Sep 27, 2024

  • Correct, that property isn't used by the client and can be removed.
  • I like the idea of the ASP.NET Healthcheck -- but I would release as a separate library. Feel free to make a PR.
  • I'm not sure about a "pre-check," as the request will fail either way—I don't see the benefit.

@ChangemakerStudios ChangemakerStudios deleted a comment Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants