Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle unnecessary file hashes #164

Open
dafyddstephenson opened this issue Nov 5, 2024 · 0 comments
Open

Handle unnecessary file hashes #164

dafyddstephenson opened this issue Nov 5, 2024 · 0 comments
Assignees
Labels
user testing Issue revealed during user testing

Comments

@dafyddstephenson
Copy link
Contributor

To instantiate an InputDataset object whose source location is remote, a file_hash is required. With the internal testing, we observed people copying the input dataset instantiation cells from notebook 1 (where remote input datasets were used) and updating the location to a local path, without changing the file_hash attribute.

The file_hash attribute is not needed for local files (so there was no consequence), but if it is provided:

  • C-Star should check the file hash and raise an error if it is incorrect
  • The error should tell the user that they don't strictly need a file hash for a local file
@dafyddstephenson dafyddstephenson added the user testing Issue revealed during user testing label Nov 5, 2024
@dafyddstephenson dafyddstephenson self-assigned this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user testing Issue revealed during user testing
Projects
None yet
Development

No branches or pull requests

1 participant