Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More relaxed typings for input-subject, comp-context-subject and comp-input-subject plugins #7

Open
loreanvictor opened this issue Jun 30, 2020 · 0 comments
Open

More relaxed typings for input-subject, comp-context-subject and comp-input-subject plugins #7

loreanvictor opened this issue Jun 30, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@loreanvictor
Copy link
Collaborator

Why should it be added?

These plugins right now only work with Subjects, however that is unnecessarily restrictive.

What should be added?

  • input-subject should require an Observable<X> & Observer<X>.
  • comp-context-subject and comp-input-subject should require Observer<X>
@loreanvictor loreanvictor added the enhancement New feature or request label Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@loreanvictor