Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vicky's merges for src/middleware/render.js from Project 1 and tests from tests/middleware.js #14

Merged
merged 5 commits into from
Sep 21, 2024

Conversation

vickyc2266
Copy link

Reduced cognitive complexity of the renderMethod which is within the processRender function of the render.js file by taking away a conditional that appears in the code more than once and putting it into a helper function with an intuitive title called checkHeadersSent(res). The function here is supposed to provide the same exact logic as the original code but just putting it in into a function and calling that function where it is needed.

UI Test
Login Successfully as admin
Able to Run Server Successfully
Able to access different and render different UI pages

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10974935758

Details

  • 5 of 6 (83.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 82.673%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/middleware/render.js 5 6 83.33%
Totals Coverage Status
Change from base Build 10841145095: 0.007%
Covered Lines: 22325
Relevant Lines: 25583

💛 - Coveralls

@evelynnchen-cmu evelynnchen-cmu removed their assignment Sep 21, 2024
Copy link

@evelynnchen-cmu evelynnchen-cmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@vickyc2266 vickyc2266 merged commit b877e68 into f24 Sep 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants