Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring code in public/src/admin/appearance/themes.js #514

Open
evelynzhengg opened this issue Sep 5, 2024 · 2 comments · May be fixed by #536
Open

Refactoring code in public/src/admin/appearance/themes.js #514

evelynzhengg opened this issue Sep 5, 2024 · 2 comments · May be fixed by #536
Assignees
@evelynzhengg
Labels
enhancement New feature or request

Comments

@evelynzhengg
Copy link

evelynzhengg commented Sep 5, 2024 •
edited
Loading

Description

Refactoring this code to not nest functions more than 4 levels deep: public/src/admin/appearance/themes.js
This is different from issue #496, because it is a separate sonarcloud warning as linked below (this one is issue 8 and the other is issue 37). Changes were made in lines 48-73.
https://sonarcloud.io/project/issues?cleanCodeAttributeCategories=ADAPTABLE&issueStatuses=OPEN%2CCONFIRMED&id=CMU-313_NodeBB&open=AZFmi_6LybYwxy-_uEU7

Community forum reference

No response
@evelynzhengg evelynzhengg added the enhancement New feature or request label Sep 5, 2024
@evelynzhengg
Copy link
Author

I would like to work on this please!

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024

Great! I assigned you (@evelynzhengg) to the issue. Have fun working on it!

@evelynzhengg evelynzhengg linked a pull request Sep 5, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evelynzhengg evelynzhengg

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@evelynzhengg