Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed the name of the button to post anonymously #35

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

tatougueye
Copy link

I just changed the name of the submit anonymous button to make it more coordinated with the other naming conventions in the NodeBB website.

@coveralls
Copy link

coveralls commented Sep 24, 2024

Pull Request Test Coverage Report for Build 11046110516

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.68%

Totals Coverage Status
Change from base Build 11027624438: 0.0%
Covered Lines: 22350
Relevant Lines: 25613

💛 - Coveralls

Copy link

@aattiyah aattiyah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. But I think you can remove the dump.rdb file.

Copy link

@aattiyah aattiyah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Member

@mohamed-elzeni mohamed-elzeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just resolve the dump.rdb conflicts.

@aattiyah aattiyah added enhancement New feature or request frontend main code is written in frontend labels Sep 25, 2024
@aattiyah aattiyah added this to the Sprint 1 milestone Sep 25, 2024
@tatougueye
Copy link
Author

Okay, thank for the feddback. I removed the dump.rdb file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend main code is written in frontend
Projects
None yet
4 participants