Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring code in src/middleware/render.js #52

Open
zanzoonh opened this issue Sep 2, 2024 · 2 comments · May be fixed by #58
Open

Refactoring code in src/middleware/render.js #52

zanzoonh opened this issue Sep 2, 2024 · 2 comments · May be fixed by #58
Assignees
@zanzoonh

Comments

@zanzoonh
Copy link

zanzoonh commented Sep 2, 2024 •
edited
Loading

Working on fixing the three SonarCloud warnings in file src/middleware/render. I need to:

  • Reduce cognitive complexity of processRender function from 16 to 15
  • Reduce cognitive complexity of loadClientHeaderFooterData function from 27 to 15
  • Reduce deep nesting of the functions.
@zanzoonh
Copy link
Author

zanzoonh commented Sep 2, 2024

I would like to work on this please!

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 2, 2024

Great! I assigned you (@zanzoonh) to the issue. Have fun working on it!

@zanzoonh zanzoonh changed the title Refactoring code in src/groups/ownership.js Refactoring code in src/modules/quickreply.js Sep 2, 2024
@zanzoonh zanzoonh changed the title Refactoring code in src/modules/quickreply.js Refactoring code in src/middleware/render.js Sep 2, 2024
@zanzoonh zanzoonh linked a pull request Sep 4, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zanzoonh zanzoonh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactoring code complexity in src/middleware/render.js zanzoonh/NodeBB
1 participant
@zanzoonh