Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dimensional-Threading-Reforged-1.18.2-1.2.7 breaks multiblocks #1

Closed
border999 opened this issue Apr 2, 2023 · 10 comments
Closed

Dimensional-Threading-Reforged-1.18.2-1.2.7 breaks multiblocks #1

border999 opened this issue Apr 2, 2023 · 10 comments

Comments

@border999
Copy link

So far I have noticed that this version breaks AE2's cabling and Bigger Reactor's reactor multiblocks.

@CCr4ft3r
Copy link
Owner

CCr4ft3r commented Apr 2, 2023

This is a design issue of AE2 since it isn't thread-safe. They don't seem interested in fixing it
AppliedEnergistics/Applied-Energistics-2#6261
WearBlackAllDay/DimensionalThreading#60

Sorry but thread-safety must be ensured by the mods.

@border999 border999 reopened this Apr 2, 2023
@border999
Copy link
Author

what about Bigger Reactors?

@CCr4ft3r
Copy link
Owner

CCr4ft3r commented Apr 2, 2023

Probably it's the same. If you want you can add your crash-report or latest.log via https://gist.github.com/ to this issue.
I can then check if the issue can be fixed by DimThread (even though it is very unlikely)

@border999
Copy link
Author

no actual crash and the log doesn't show anything as far as I can tell.

@border999
Copy link
Author

I might recommend just loading up your mod and add in bigger reactors

@Kasualix
Copy link

Kasualix commented Apr 3, 2023

Trillions of modders don't write codes with thread-safety. Fact. It's just... quite unlikely, in trillions of aspects.

@CCr4ft3r
Copy link
Owner

CCr4ft3r commented Apr 3, 2023

After adding the mod I couldn't found "reactor multiblocks".

Please provide the following informations:
-describe the unexpected behaviour
-describe the expected behaviour
-steps to reproduce it (for example building something specific)

@border999
Copy link
Author

bigger reactors uses a combination of Reactor Casings, reactor glass, control rods, power taps, fuel input blocks, and a reactor terminal to, in a cuboidal configuration, create a multiblock reactor. The simplest reactor I can think to do is a literal 3x3x3 with one control rod on top, a terminal on one face, a power tap on another, followed by at least one fuel input block and every other block being reactor casing surround the one fuel rod.

@border999
Copy link
Author

with all of that being said. The multiblock that is supposed to form from these blocks being placed together in a valid manner does not occur with your mod installed.

@CCr4ft3r
Copy link
Owner

CCr4ft3r commented Apr 3, 2023

Sorry but I really have no idea about this. Since there is no exception, crash or log output it's probably related to Better Reactors internals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants