-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Create a try_filter_entry()
#131
Comments
I think the ideal way to do this would be to create |
OK, that makes sense. I'll try to get a PR for that when I find the time. Could you assign this to me so I don't forget? |
Done! Thanks! |
@zicklag are you working on this or can I take it? I implemented a workaround in a personal project but would like to contribute back to this crate instead 😃 |
@ThinkChaos Go ahead and take it. 😃 I never got back to this, so it would be appreciated! 👍 |
I am using this library and have run into the need to capture a potential error inside of the
filter_entry
predicate. I asked in a forum topic about my problem and the response was that the best way to accomplish it would be with atry_filter_entry
iterator so that I could return a result inside of the filter predicate.I did a quick check of the source code to see how I might be able to implement that, but I was wondering if you might have any guidance on how you would want that implemented.
I haven't ever written an iterator before, but it looks like, if I wanted to create a
FilterEntry
iterator that it would be nearly identical to the existingTryFilterEntry
iterator, but not quite the same.Is there any way to share most of the implementation without duplicating code, or is it better just to create a copy of
FilterEntry
and the make the changes necessary.The text was updated successfully, but these errors were encountered: