Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]Medusa support #172

Open
Merrick28 opened this issue Feb 18, 2020 · 3 comments
Open

[Feature Request]Medusa support #172

Merrick28 opened this issue Feb 18, 2020 · 3 comments
Labels
approved Enhancement or request that was approved to be worked on help-wanted Extra attention is needed more-info-requested Waiting on more information request This is a request

Comments

@Merrick28
Copy link

Is your feature request related to a problem? Please describe.
I tired to use sickchill backend to use Medusa, and it's not working.

Describe the solution you'd like
The Medusa api does not support the type "snatched"
The error message is

{"data": {}, "message": "param: 'type' with given value ['missed', 'today', 'soon', 'later', 'snatched']  is out of allowed range ['later', 'missed', 'soon', 'today']", "result": "error"}

Describe alternatives you've considered
I would like to create another provider, first clone of sickchill, that removes the "snatched" type from the api. This provider could evolve if Medusa api differs later from sickchill api.

@Merrick28 Merrick28 added the awaiting-triage Request awaiting triage label Feb 18, 2020
@samwiseg0 samwiseg0 added help-wanted Extra attention is needed more-info-requested Waiting on more information request This is a request and removed awaiting-triage Request awaiting triage labels Feb 18, 2020
@samwiseg0
Copy link
Member

samwiseg0 commented Feb 18, 2020

Looking through their api documentation there does not apear to be any endpoints that will give what is missing, coming soon, being downloaded, or on today. Without any of those endpoints being documented we cannot develop for it.

Can you provide the api documentation for the endpoints above?

@Merrick28
Copy link
Author

No, nothing on their documentation... For now I only modified the varken/sicckchill.py file, and changed line 25 from

params = {'cmd': 'future', 'paused': 1, 'type': 'missed|today|soon|later|snatched'}

to

params = {'cmd': 'future', 'paused': 1, 'type': 'missed|today|soon|later'}

to make it work, but I guess as it's not an official api, it may not last.

@samwiseg0
Copy link
Member

samwiseg0 commented Feb 19, 2020

Correct. As you pointed out they removed an endpoint from the API. Who knows what they will remove or add next. That would be the issue. Since there is nothing official from the developers we are at their mercy. In this state we have to reverse engineer the API and there is no telling if they will change it again. If the Medusa community can setup some documentation and have a stable API then we can develop for it.

I will leave this open if/when Medusa is at a point that it can be developed for. Secondly, those looking for a solution to get around the issue can use the information you provided in the comment above. We unfortunately cannot support the code modification but it is there for others if they wish to modify the code each release.

@samwiseg0 samwiseg0 added the approved Enhancement or request that was approved to be worked on label Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Enhancement or request that was approved to be worked on help-wanted Extra attention is needed more-info-requested Waiting on more information request This is a request
Projects
None yet
Development

No branches or pull requests

2 participants