Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose SLPJS completely #28

Open
jcramer opened this issue Mar 8, 2019 · 3 comments
Open

Expose SLPJS completely #28

jcramer opened this issue Mar 8, 2019 · 3 comments

Comments

@jcramer
Copy link

jcramer commented Mar 8, 2019

Some applications may need to access additional methods that are not wrapped by SLP-SDK. For these use cases, it would be useful to expose the whole SLPJS.

I've seen other users have this same request, and I've come across this in consuming SLP-SDK myself.

@christroutner
Copy link
Contributor

What is the pro/con of including slpjs with SLP-SDK vs the developer requireing the slpjs separately in their application?

@jcramer
Copy link
Author

jcramer commented Mar 12, 2019

Pros:

  • Same version of SLPJS can be accessed, don't have to worry about type/feature mismatch with whatever version SLP-SDK is using
  • SLP-SDK is a Software Developers Kit and therefore should be the one stop shop for gaining access to all SLP related code (and recommended libraries associated with SLP)

Cons:

  • ?

@Ekliptor
Copy link

Ekliptor commented Jun 6, 2019

I'm also for exposing SLPJS completely.

A possible con is that WebPack Tree Shaking will have less code to eliminate https://webpack.js.org/guides/tree-shaking/
But seeing that a minified bundle.js of slp-sdk v4.4.0 which just exposed the SDK is already 1.28 MB (see code below), it seems to me there is little code to eliminate either way.

import * as SLP from "slp-sdk";
window.SLP = SLP;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants