Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give bonus damage when attacking a beast with the same name as your item #330

Closed
loothero opened this issue May 12, 2023 · 1 comment
Closed

Give bonus damage when attacking a beast with the same name as your item #330

loothero opened this issue May 12, 2023 · 1 comment
Assignees
@loothero
Labels
Context: coupled interact with some parts of the codebase Difficulty: intermediate mobilise some notions about the field, but can be learned while doing Duration: under a day wil take up to one day State: open ready for contribution Type: feature a new feature to implement
Milestone
Adventurer Arcade...

Comments

@loothero
Copy link
Contributor

items and beasts have two parts to their name - a name prefix and a suffix.

The prefix consists of 68 names
The suffix consists of 18 names

The bonus damage should reflect the above probability such that:
Matching on suffix alone deals 2x damage
Matching on prefix alone deals 4x damage
Matching on both (highly unlikely) deals 50x damage (I considered TKO but when we eventually get #309 and end up with a rogue world boss, if 50x isn't TKO, it will make the battle even more epic)
@loothero loothero added Type: feature a new feature to implement Difficulty: intermediate mobilise some notions about the field, but can be learned while doing State: open ready for contribution Duration: under a day wil take up to one day Context: coupled interact with some parts of the codebase labels May 12, 2023
@loothero loothero self-assigned this May 19, 2023
@loothero loothero added this to the Adventurer Arcade Game MPG milestone May 20, 2023
loothero added a commit that referenced this issue May 20, 2023
@loothero
signficantly improves combat system:
cbcc52a 
- Closes #330:  damage bonus for weapon name prefixes
- Closes #346: elemental damage now -50%, 100%, or 150% bonus
- Refactors core damage calculation to separate each bonus for better clarity and auditing
- Updates test cases and fixes majority of previous failures
@loothero
Copy link
Contributor Author

Implemented as part of cbcc52a

Current implementation is for attack only which is to say this will only apply to weapons atm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@loothero loothero

Labels
Context: coupled interact with some parts of the codebase Difficulty: intermediate mobilise some notions about the field, but can be learned while doing Duration: under a day wil take up to one day State: open ready for contribution Type: feature a new feature to implement
Projects
None yet
Milestone
Adventurer Arcade Game MPG
Development

No branches or pull requests
1 participant
@loothero