Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: providing empty button styles causes unreadable goldens #62

Open
1 task done
jeroen-meijer opened this issue Jun 2, 2022 · 1 comment
Open
1 task done
Labels
bug Something isn't working

Comments

@jeroen-meijer
Copy link
Collaborator

Is there an existing issue for this?

  • I have searched the existing issues.

Version

0.3.3

Description

Reproducible example gist can be found here.

In platform tests (and I suspect CI tests as well), if a Text is built but no default text style font family is found, it looks like "Ahem" is used as a fallback value, instead of "Roboto".

Steps to reproduce

  1. Run a golden test and provide it a Theme with a textButtonTheme. Assign the style of this theme to TextButton.styleFrom. Provide this constructor an empty TextStyle.
  2. Set this as the default theme in the AlchemistConfig or PlatformGoldensConfig.
  3. Run the test.

Expected behavior

Default to "Roboto" when no font family is found.

Screenshots

image

Additional context and comments

No response

@jeroen-meijer jeroen-meijer added the bug Something isn't working label Jun 2, 2022
@jeroen-meijer
Copy link
Collaborator Author

CC @alestiago

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant