Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dualis screen improvements #23

Open
Bennik2000 opened this issue Aug 4, 2020 · 8 comments
Open

Dualis screen improvements #23

Bennik2000 opened this issue Aug 4, 2020 · 8 comments
Labels
enhancement New feature or request

Comments

@Bennik2000
Copy link
Owner

The dualis screen could take some improvements.

  • If the user is logged in, after a while the login cookie times out and no further requests can be made without restarting the app
  • When something was loaded, it is cached and cannot be refreshed
  • The user can not log himself out
  • When the password is already saved, the user has to press the login button to log in. This could be done automatically as soon as the dualis page is accessed
@Bennik2000 Bennik2000 added the enhancement New feature or request label Aug 4, 2020
@Bennik2000
Copy link
Owner Author

Bennik2000 commented Aug 13, 2020

The user can not log himself out

A logout button was implemented in 3a11e85

@Bennik2000
Copy link
Owner Author

When the password is already saved, the user has to press the login button to log in. This could be done automatically as soon as the dualis page is accessed

Thinking of it, it is not that bad. When the user is low on internet volume or has a slow bandwidth, it is better to not automatically login.

@CodingMarco
Copy link
Collaborator

When the user is low on internet volume or has a slow bandwidth, it is better to not automatically login.

I don't quite agree or I don't understand your exact point. I limited the download speed of my phone to 64 kbit/s and tried it out. Of course it takes a while until you are logged in and the results are loaded, but you would have to wait anyway.
Also, I think if you consider every time you look at your results when you are awaiting them, I think that you have a decent internet connection most of the time.
I just think that this feature would save a lot of time and unnecessary clicking.

@Bennik2000
Copy link
Owner Author

I meant, that if the user is thight in data volume (e.g. there are people with 100mb and they are counting every mb of it). However the app is for students, you could assume that many have more than 1Gb data volume.

Maybe the "automatic dualis login" could be disabled in the settings?

@CodingMarco
Copy link
Collaborator

I think a setting would be appropriate. But the default should be to automatically login. I mean, even if someone only had 100MB of data, it wouldn't make a difference; if they wanted to see their results, they would have to login anyway.

@Bennik2000
Copy link
Owner Author

I agree with this,
Would you like to implement it or should I do that?

@CodingMarco
Copy link
Collaborator

I would like to try it, but I don't know how long it will take ;)

@Bennik2000
Copy link
Owner Author

If the user is logged in, after a while the login cookie times out and no further requests can be made without restarting the app

I am working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants