Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unusual number of luxtronik2_data_update listener2 #224

Open
5 tasks
AJediIAm opened this issue Dec 26, 2023 · 1 comment
Open
5 tasks

unusual number of luxtronik2_data_update listener2 #224

AJediIAm opened this issue Dec 26, 2023 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed wontfix This will not be worked on

Comments

@AJediIAm
Copy link
Contributor

I noticed that under Developer Tools > Events, the luxtronik2_data_update event has 25 listeners. This is noticable because:

  • It is the only integration I have seen with it's own listeners
  • it is the 3rd most subscribed to event (only surpassed by HA stop and registry updates).

While many integrations need to listen for updates, none of them seem to use their own event handler and none of them have so many listeners. The developer documentation state attributed events should be used instead. I expect that using events like most other integrations will improve UI responsiveness template sensors updates and overall stability and performance.

The Luxtronik integration heavily impacts the performance, responsiveness and stability of the entire Home Assistant platform. Disabling the integration has a noticable positive impact. My theory is that the non-standard use of events contributes to this.
I doubt the use of custom event listeners is acceptable for a native HA integration (assuming this is still a goal for this integration).

Proposal:

  • How do custom event listeners differ from other integrations (code comparison).
  • How can we test/validate the impact of custom event listeners?
  • Discuss the possible impact of custom event listener to standard event listener.
  • Choose a way forward.
  • Update integration (if needed).
@BenPru
Copy link
Owner

BenPru commented Jan 1, 2024

This is old code and I can remove it next time.
But it is never fired so it can not have an big impact.
And in future release I would like to use events and I have to re add it.

@BenPru BenPru added enhancement New feature or request help wanted Extra attention is needed wontfix This will not be worked on labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants