Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs in option data code #1

Open
qadeer-cyber opened this issue Mar 1, 2023 · 0 comments
Open

Bugs in option data code #1

qadeer-cyber opened this issue Mar 1, 2023 · 0 comments

Comments

@qadeer-cyber
Copy link

The date_to_timestamp function should have a different name since it has the same name as the input parameter date.
The option_data function may return duplicated data since it does not remove duplicate trades.
The iv_smile function should use the _data variable to extract the customdata for the plot instead of option_data.
The iv_smile function uses option_data instead of _data when creating the plot's text.
The iv_smile function's title contains min(option_data['date_time']).date() and max(option_data['date_time']).date(), which will return the minimum and maximum dates in the whole option_data DataFrame, not just the filtered dates. The title should use start_date and end_date instead.
The iv_smile function's hovertemplate does not use the _data variable to display information for the individual maturities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant