Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter TODO's and FIXME's #184

Open
darrenchurchill opened this issue Mar 25, 2019 · 2 comments
Open

Filter TODO's and FIXME's #184

darrenchurchill opened this issue Mar 25, 2019 · 2 comments
Assignees

Comments

@darrenchurchill
Copy link
Collaborator

I think it might be a good idea to run through all our files and clean outdated TODO's and fix any important ones that remind us of forgotten issues.

For example, I can think of one off the top of my head: In task.py, what happens when init fails?

There might be a number of other similarly important comments laying around in the source.

@Carter90
Copy link
Contributor

Agreed and for that one look to see if task.py re-spawns correctly.

@Carter90
Copy link
Contributor

Carter90 commented Mar 25, 2019

Just quick grep
mapping/src/mapping.cpp:69:// todo: what's a good number for sonar_view_range?
mapping/src/mapping.cpp:73:// todo: limit clear_poly left and right ranges using sonar_view_range?
mapping/src/mapping.cpp:75:// todo: what's a good number for sonar_obst_depth?
mapping/src/mapping.cpp:432: // todo: put this back now that path straightening is in?
mapping/src/mapping.cpp:661: // todo: are these rates good?
mapping/src/mapping.cpp:829: * todo: Confirm on physical rover that 8-connected passable() neighbors check is fast enough

mobility/src/mobility/behavior/gohome.py:122: # todo: is it necessary to check that we can still see a home tag? or does dropoff handle it ok?

mobility/src/mobility/planner.py:4:todo: raise HomeExceptions from Planner.drive_to()?
mobility/src/mobility/planner.py:5:todo: is reusing PathException in Planner.drive_to() ok?
mobility/src/mobility/planner.py:6:todo: is using swarmie.drive(), turn, etc with throw=False and just geting the MoveResult ok?
mobility/src/mobility/planner.py:7:todo: refactor to make target avoidance optional?
mobility/src/mobility/planner.py:8:todo: is setting x pos = 0 good in _get_angle_and_dist_to_avoid() when radius is too small?
mobility/src/mobility/planner.py:1152: # todo: is this big enough, or too big?

mobility/scripts/cal_imu.py:34:todo: pick validation thresholds that make sense. Something that means the 2D calibration is likely going to be better.
mobility/scripts/cal_imu.py:35:todo: ok for node to crash if extended cal file is missing or corrupt?


diagnostics/src/diagnostics/diags.py:91: # FIXME: Need to sub the rover's wifi interface
mobility/scripts/task.py:130: # FIXME: What should happen when init fails?
mobility/scripts/task.py:131: self.print_state('Init failed! FIXME!.')
mobility/scripts/task.py:164: # FIXME: What happens when we don't find home?
mobility/scripts/task.py:192: # FIXME: What should be done here?
mobility/scripts/task.py:205: # FIXME: What do we do with bugs in task code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants