-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make TelemetryOptions optional and generic, but default to the standard Azure User-Agent format for azure_core #1753
Comments
We could make use of features. 🤔 |
@JeffreyRichter @RickWinter what do you think from an unbranding perspective? Imagine we defined a "microsoft" or "azure" feature in |
It's not ideal. What if some customer uses an Azure SDK and also a non-Azure SDK both of which are built on typespec_client_core? Will this work right? We wouldn't want the Azure-specific functionality turned on for a non-Azure SDK and vice versa. And, ideally, the code for typespec_client_core (or slightly-different versions of it) would not exist multiple times in the same process. |
People can specify this feature themselves, though. It's just not on by default, just like XML support. Prototype: heaths#76 We could devise a way to pass stuff in, but that would be more work and still something customers can do. Features make this easier, I think. |
Nope. Features won't work: #1754 (comment). |
PR #1751 temporarily disables
TelemetryOptions
as part of the unbranding work that refactored most ofazure_core
intotypespec_client_core
. Since all it really does is set theuser-agent
header, we could make this generic - optional as well for clients that may not want any telemetry of any sort - but default it to some prefix / template when creating anazure_core::Pipeline
.The text was updated successfully, but these errors were encountered: